Smoother Animation #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I am Ty. I love this package that you built! I'm currently incorporating it into my app. It's amazing. Thank you for making it. I made some other changes to this but I figured I could say thank you by adding this in. I imagine the animation as it is, is intentional but maybe it wasn't. Anyways, please check it out :) Review of Changes -------------------- 1. Prevent cancellationWidget text from truncating and giving it a fade option - (maybe this could be a user specified option) 2. Smoothed out hide animation by removing _animate - (was there a reason for this?) 3. Added padding and adjusted container width to suit the new changes Thanks again! I hope you are doing well with COVID-19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am Ty. I love this package that you built! I'm currently incorporating it into my app. It's amazing. Thank you for making it. I made some other changes to this but I figured I could say thank you by adding this in. I imagine the animation as it is, is intentional but maybe it wasn't. Anyways, please check it out :)
Review of Changes
Thanks again! I hope you are doing well with COVID-19